legcord: refactor; 1.1.0 -> 1.1.1#390517
Merged
khaneliman merged 3 commits intoNixOS:masterfrom Mar 22, 2025
Merged
Conversation
13 tasks
github-actions
bot
added
10.rebuild-darwin: 0
Member
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5292 |
nyabinary
force-pushed
the
legcord-refactor
branch
from
2675335 to
f46fc89
Compare
wrmilling
approved these changes
Mar 21, 2025
Member
wrmilling
left a comment
wrmilling
left a comment
There was a problem hiding this comment.
As far as I can tell with limited testing of venmic and legcord, seems to work without errors:
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 390517
x86_64-linux
✅ 1 package built:
- legcord
Member
|
Actually, one change I forgot in the review, you should split up your commits if I am not mistaken:
|
nyabinary
force-pushed
the
legcord-refactor
branch
from
f46fc89 to
4d50cf2
Compare
Contributor
Author
done :3 |
water-sucks
approved these changes
Mar 21, 2025
Member
water-sucks
left a comment
water-sucks
left a comment
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 390517
x86_64-linux
✅ 1 package built:
- legcord
water-sucks
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Refactor to use
finalAttrsRefactor to remove
with libusage inmetaUpdate to
1.1.1Make the
.desktopfile more accurateAdd
nyabinary(me) as a maintainerUse
taginstead ofrevFix
venmic(thanks @wrmilling and @water-sucks); supersedes #388827nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.